Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: rename some params and reduce default bitmapCardinalityLimit… #36138

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Sep 10, 2024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 10, 2024
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Sep 10, 2024

rerun ut

@mergify mergify bot added the ci-passed label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (3123093) to head (79b14cb).
Report is 33 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36138      +/-   ##
==========================================
- Coverage   81.59%   81.57%   -0.02%     
==========================================
  Files        1267     1268       +1     
  Lines      150973   151077     +104     
==========================================
+ Hits       123190   123245      +55     
- Misses      22891    22935      +44     
- Partials     4892     4897       +5     
Files with missing lines Coverage Δ
internal/core/src/index/BitmapIndex.cpp 82.33% <100.00%> (ø)
internal/core/src/index/HybridScalarIndex.cpp 78.77% <100.00%> (ø)
internal/proxy/task_index.go 84.05% <100.00%> (ø)
pkg/util/paramtable/autoindex_param.go 87.94% <100.00%> (+0.53%) ⬆️
pkg/util/paramtable/component_param.go 98.27% <ø> (-0.01%) ⬇️

... and 42 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5e5e87c into milvus-io:master Sep 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants