Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cp]Change deltalog memory estimation factor to one #36035

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #36031
pr: #36033

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Sep 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 6, 2024
@XuanYang-cn XuanYang-cn changed the title fix: [cp]Change deltalog memory estimation fator to one fix: [cp]Change deltalog memory estimation factor to one Sep 6, 2024
@XuanYang-cn XuanYang-cn added this to the 2.4.11 milestone Sep 6, 2024
@mergify mergify bot added the ci-passed label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.28%. Comparing base (45b2049) to head (3c0070e).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36035      +/-   ##
==========================================
- Coverage   85.07%   80.28%   -4.79%     
==========================================
  Files         790     1057     +267     
  Lines      114956   139300   +24344     
==========================================
+ Hits        97801   111841   +14040     
- Misses      12887    23192   +10305     
+ Partials     4268     4267       -1     
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment_loader.go 72.20% <100.00%> (-0.09%) ⬇️

... and 314 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 6, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 64e109d into milvus-io:2.4 Sep 6, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the cp24/delete-mem-est branch September 9, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants