Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Add delete buffer related quota logic (#35918) #35997

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #35128 #35918
See also #35303

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Sep 5, 2024
Copy link
Contributor

mergify bot commented Sep 5, 2024

@congqixia Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/enhancement Issues or changes related to enhancement labels Sep 5, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 80.14184% with 28 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (6158ad3) to head (978787d).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/quota_center.go 26.31% 28 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35997      +/-   ##
==========================================
+ Coverage   71.92%   81.17%   +9.25%     
==========================================
  Files        1057     1057              
  Lines      139105   139239     +134     
==========================================
+ Hits       100051   113031   +12980     
+ Misses      34779    21943   -12836     
+ Partials     4275     4265      -10     
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator.go 87.07% <100.00%> (+0.04%) ⬆️
...uerynodev2/delegator/deletebuffer/delete_buffer.go 98.66% <100.00%> (+18.66%) ⬆️
.../querynodev2/delegator/deletebuffer/delete_item.go 100.00% <100.00%> (ø)
...odev2/delegator/deletebuffer/list_delete_buffer.go 100.00% <100.00%> (ø)
internal/querynodev2/metrics_info.go 87.57% <100.00%> (+1.09%) ⬆️
pkg/util/paramtable/quota_param.go 79.77% <100.00%> (+0.74%) ⬆️
internal/rootcoord/quota_center.go 84.94% <26.31%> (-2.60%) ⬇️

... and 229 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 5, 2024
@tedxu
Copy link
Contributor

tedxu commented Sep 5, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit da0bc22 into milvus-io:2.4 Sep 5, 2024
15 checks passed
@congqixia congqixia deleted the cp24/35918 branch September 5, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants