Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SkipIndex cause segment fault #35908

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Sep 2, 2024

issue: #35882
pr: #35907

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 2, 2024
@chyezh chyezh force-pushed the fix_skip_index_segment_fault_2_4 branch 2 times, most recently from 6f222e5 to e4abe4d Compare September 3, 2024 01:44
@mergify mergify bot added the ci-passed label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (268c60c) to head (74c6b91).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35908      +/-   ##
==========================================
- Coverage   84.99%   81.13%   -3.86%     
==========================================
  Files         789     1056     +267     
  Lines      115091   139412   +24321     
==========================================
+ Hits        97818   113110   +15292     
- Misses      12977    21999    +9022     
- Partials     4296     4303       +7     
Files with missing lines Coverage Δ
internal/core/src/index/SkipIndex.cpp 100.00% <100.00%> (ø)
internal/core/src/index/SkipIndex.h 95.65% <100.00%> (ø)

... and 292 files with indirect coverage changes

@chyezh chyezh force-pushed the fix_skip_index_segment_fault_2_4 branch from e4abe4d to 74c6b91 Compare September 3, 2024 06:57
@mergify mergify bot removed the ci-passed label Sep 3, 2024
@czs007
Copy link
Collaborator

czs007 commented Sep 3, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Sep 3, 2024
@sre-ci-robot sre-ci-robot merged commit dffbc17 into milvus-io:2.4 Sep 3, 2024
15 checks passed
@chyezh chyezh deleted the fix_skip_index_segment_fault_2_4 branch September 3, 2024 11:11
jaime0815 pushed a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants