Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: streaming service stat manager crash when pv stat is empty #35439

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Aug 13, 2024

issue: #33285

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Aug 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Aug 13, 2024
@chyezh chyezh force-pushed the fix_streaming_service_stat_manager_crash branch from d4a2c64 to ee02655 Compare August 13, 2024 06:05
Copy link
Contributor

mergify bot commented Aug 13, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Aug 13, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Aug 13, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_streaming_service_stat_manager_crash branch from ee02655 to ba717e2 Compare August 13, 2024 14:06
@chyezh
Copy link
Contributor Author

chyezh commented Aug 14, 2024

rerun ut

@mergify mergify bot added the ci-passed label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (f5b4a97) to head (ba717e2).
Report is 4 commits behind head on master.

Files Patch % Lines
...er/wal/interceptors/segment/stats/stats_manager.go 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35439      +/-   ##
==========================================
- Coverage   81.54%   72.47%   -9.08%     
==========================================
  Files        1225     1225              
  Lines      143876   143882       +6     
==========================================
- Hits       117330   104274   -13056     
- Misses      22106    35177   +13071     
+ Partials     4440     4431       -9     
Files Coverage Δ
...er/wal/interceptors/segment/stats/stats_manager.go 94.93% <69.23%> (-5.07%) ⬇️

... and 245 files with indirect coverage changes

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0868a97 into milvus-io:master Aug 14, 2024
13 of 15 checks passed
@chyezh chyezh deleted the fix_streaming_service_stat_manager_crash branch August 14, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants