Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add forward delete max batch size #35343

Conversation

congqixia
Copy link
Contributor

Separate delete data into batches if any delete data size exceeds the confgured max batch size

Related to #35303

Separate delete data into batches if any delete data size exceeds the
confgured max batch size

Related to milvus-io#35303

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Aug 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 7, 2024
@mergify mergify bot added the ci-passed label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 69.11765% with 21 lines in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (c6253f9) to head (d2de474).
Report is 279 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/delegator/delegator_data.go 65.57% 17 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35343      +/-   ##
==========================================
- Coverage   81.56%   72.37%   -9.20%     
==========================================
  Files        1220     1220              
  Lines      143417   143447      +30     
==========================================
- Hits       116985   103821   -13164     
- Misses      22002    35181   +13179     
- Partials     4430     4445      +15     
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.49% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/delegator/delegator_data.go 86.61% <65.57%> (-1.75%) ⬇️

... and 235 files with indirect coverage changes

Copy link

stale bot commented Sep 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Sep 7, 2024
@stale stale bot closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines. stale indicates no udpates for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants