enhance: Purge delete buffer asap after all L0 segment ready #35304
Conversation
See also milvus-io#35303 Signed-off-by: Congqi Xia <[email protected]>
congqixia
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35304 +/- ##
===========================================
+ Coverage 72.41% 84.82% +12.40%
===========================================
Files 1217 944 -273
Lines 143721 119423 -24298
===========================================
- Hits 104075 101298 -2777
+ Misses 35225 13698 -21527
- Partials 4421 4427 +6
|
| @@ -668,6 +668,9 @@ func (sd *shardDelegator) loadStreamDelete(ctx context.Context, | |||
| } | |||
| } | |||
|
|
|||
| // if segment level is not L0, delete buffer could be purged safely according to target checkpoint | |||
| sd.deleteBuffer.TryDiscard(position.GetTimestamp()) | |||
There was a problem hiding this comment.
should we change the synctarget version func?
instead use checkpoint timestamp, we can use L0 segment's last message?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
See also #35303