enhance:[cherry-pick] Support calculate segment maxRows with diskann #35155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
xiaocai2333
force-pushed
the
clustering_segment_size_disk
branch
from
80e65b2 to
1e590be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #35155 +/- ##
==========================================
+ Coverage 81.12% 81.15% +0.02%
==========================================
Files 1052 1052
Lines 136740 136764 +24
==========================================
+ Hits 110929 110984 +55
+ Misses 21603 21580 -23
+ Partials 4208 4200 -8
|
xiaocai2333
force-pushed
the
clustering_segment_size_disk
branch
from
1e590be to
41e0745
Compare
wayblink
reviewed
Aug 1, 2024
| collMeta, err := m.handler.GetCollection(ctx, collectionID) | ||
| if err != nil { | ||
| log.Warn("failed to get collection", zap.Int64("collectionID", collectionID), zap.Error(err)) | ||
| return Params.DataCoordCfg.SegmentMaxSize.GetAsInt64() * 1024 * 1024 |
There was a problem hiding this comment.
It supposed not happen in normal？will be blocked even though return a value here？
There was a problem hiding this comment.
yeah， you are right, it should return an error.
|
/lgtm |
Signed-off-by: Cai Zhang <[email protected]>
xiaocai2333
force-pushed
the
clustering_segment_size_disk
branch
from
41e0745 to
1273a45
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, xiaocai2333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #34495
master pr: #35076