Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] Fix data race for clustering buffer writer #35146

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #34495

master pr: #35145

Signed-off-by: Cai Zhang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (0bec383) to head (4178f1d).
Report is 8 commits behind head on 2.4.

Files Patch % Lines
...ternal/datanode/compaction/clustering_compactor.go 44.44% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35146      +/-   ##
==========================================
+ Coverage   81.07%   81.08%   +0.01%     
==========================================
  Files        1052     1052              
  Lines      136710   136710              
==========================================
+ Hits       110831   110849      +18     
+ Misses      21665    21652      -13     
+ Partials     4214     4209       -5     
Files Coverage Δ
...ternal/datanode/compaction/clustering_compactor.go 65.91% <44.44%> (+0.26%) ⬆️

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 31, 2024
@xiaocai2333 xiaocai2333 added this to the 2.4.7 milestone Aug 1, 2024
@czs007
Copy link
Collaborator

czs007 commented Aug 1, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added the manual-pass manually set pass before ci-passed labeled label Aug 1, 2024
@sre-ci-robot sre-ci-robot merged commit f718410 into milvus-io:2.4 Aug 1, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants