Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean vector memory #33692

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Jun 6, 2024

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 6, 2024
Copy link
Contributor

mergify bot commented Jun 6, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 6, 2024

@zhagnlu ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: luzhang <[email protected]>
@zhagnlu zhagnlu force-pushed the fix_clean_memory branch from 43658c1 to 2101028 Compare June 6, 2024 11:44
@czs007
Copy link
Collaborator

czs007 commented Jun 6, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (cfea3f4) to head (2101028).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33692      +/-   ##
==========================================
- Coverage   81.75%   81.34%   -0.41%     
==========================================
  Files        1019     1021       +2     
  Lines      130732   132337    +1605     
==========================================
+ Hits       106876   107648     +772     
- Misses      19834    20653     +819     
- Partials     4022     4036      +14     
Files Coverage Δ
internal/core/src/mmap/Column.h 90.56% <100.00%> (-0.43%) ⬇️

... and 226 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 7, 2024
@sre-ci-robot sre-ci-robot merged commit 6ce9df9 into milvus-io:master Jun 7, 2024
15 checks passed
zhagnlu added a commit to zhagnlu/milvus that referenced this pull request Jun 7, 2024
sre-ci-robot pushed a commit that referenced this pull request Jun 7, 2024
pr: #33692

Signed-off-by: luzhang <[email protected]>
Co-authored-by: luzhang <[email protected]>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants