Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add related bin log size into search stream reduce #33010

Closed
wants to merge 7 commits into from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented May 13, 2024

issue: #30436

  • Lost related bin log size when enabling search stream reduce.

@sre-ci-robot sre-ci-robot requested review from aoiasd and congqixia May 13, 2024 06:55
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label May 13, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 13, 2024
Copy link
Contributor

mergify bot commented May 13, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 70.68966% with 102 lines in your changes are missing coverage. Please review.

Project coverage is 82.09%. Comparing base (230c88b) to head (aa94a3c).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33010      +/-   ##
==========================================
+ Coverage   82.07%   82.09%   +0.02%     
==========================================
  Files        1007      999       -8     
  Lines      127668   128070     +402     
==========================================
+ Hits       104778   105143     +365     
- Misses      18915    18951      +36     
- Partials     3975     3976       +1     
Files Coverage Δ
internal/core/src/common/Types.h 31.45% <ø> (+3.43%) ⬆️
internal/core/src/index/Index.h 100.00% <ø> (ø)
internal/core/src/index/InvertedIndexTantivy.cpp 89.47% <100.00%> (ø)
internal/core/src/index/InvertedIndexTantivy.h 47.36% <ø> (ø)
internal/core/src/index/ScalarIndexSort.cpp 74.63% <100.00%> (+0.21%) ⬆️
internal/core/src/index/ScalarIndexSort.h 57.14% <ø> (ø)
internal/core/src/index/StringIndexMarisa.h 100.00% <ø> (ø)
internal/core/src/index/VectorDiskIndex.h 18.18% <ø> (ø)
internal/core/src/index/VectorMemIndex.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentGrowingImpl.h 81.35% <100.00%> (+0.99%) ⬆️
... and 31 more

... and 197 files with indirect coverage changes

@chyezh chyezh closed this May 14, 2024
@chyezh chyezh deleted the fix_binlog_size branch August 5, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants