Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use collection default consistency level for restv2 #32956

Conversation

congqixia
Copy link
Contributor

Set UseDefaultConsistency to true so that restv2 read API shall use collection consistency level setting correctly.

Set `UseDefaultConsistency` to true so that restv2 read API shall use
collection consistency level setting correctly.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels May 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 10, 2024
Copy link
Contributor

mergify bot commented May 10, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@PowderLi
Copy link
Contributor

/lgtm

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.02%. Comparing base (2568985) to head (9f92c29).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #32956   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files        1007     1007           
  Lines      127603   127603           
=======================================
+ Hits       104664   104670    +6     
  Misses      18954    18954           
+ Partials     3985     3979    -6     
Files Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 89.14% <100.00%> (ø)

... and 29 files with indirect coverage changes

Copy link
Contributor

mergify bot commented May 10, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 10, 2024
@sre-ci-robot sre-ci-robot merged commit c0e62e6 into milvus-io:master May 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants