Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: optimize plan parser pool to avoid unnessary recycle #32869

Merged
merged 1 commit into from
May 11, 2024

Conversation

xiaofan-luan
Copy link
Collaborator

fix #32868
plan parser takes too much cpu on high qps,this pr try to avoid create lexer and parser too freequent

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label May 8, 2024
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. approved labels May 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 8, 2024
Copy link
Contributor

mergify bot commented May 8, 2024

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 8, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 9, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 10, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.73%. Comparing base (f7d2911) to head (ae239c1).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32869      +/-   ##
==========================================
- Coverage   82.02%   81.73%   -0.30%     
==========================================
  Files        1006     1007       +1     
  Lines      127363   127623     +260     
==========================================
- Hits       104466   104308     -158     
- Misses      18923    19340     +417     
- Partials     3974     3975       +1     
Files Coverage Δ
internal/parser/planparserv2/pool.go 100.00% <100.00%> (+13.33%) ⬆️

... and 42 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 10, 2024
@czs007
Copy link
Collaborator

czs007 commented May 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [czs007,xiaofan-luan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 36f1ea9 into milvus-io:master May 11, 2024
15 checks passed
Copy link

@Yherealtita Yherealtita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: plan parser take too much cpu on high concurrency cases
4 participants