Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: lock tantivy dependencies (#31688) #31690

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

longjiquan
Copy link
Contributor

issue: #31681
pr: #31688

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Mar 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (bd6f123) to head (6e915ac).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31690      +/-   ##
==========================================
- Coverage   80.81%   80.74%   -0.08%     
==========================================
  Files         974      974              
  Lines      137886   137886              
==========================================
- Hits       111429   111331      -98     
- Misses      22746    22835      +89     
- Partials     3711     3720       +9     

see 33 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Mar 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ef267b5 into milvus-io:2.4 Mar 29, 2024
14 checks passed
@longjiquan longjiquan deleted the cp-31688 branch March 29, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants