Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [Cherry-pick] Use gotestsum to run go unit test (#31622) #31654

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #31622
See also #31490


@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. approved area/compilation labels Mar 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Mar 27, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (b8f849e) to head (e00e89f).
Report is 13 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31654      +/-   ##
==========================================
+ Coverage   80.68%   80.75%   +0.06%     
==========================================
  Files         974      974              
  Lines      137806   137852      +46     
==========================================
+ Hits       111192   111324     +132     
+ Misses      22891    22808      -83     
+ Partials     3723     3720       -3     

see 40 files with indirect coverage changes

@yellow-shine
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit c80b440 into milvus-io:2.4 Mar 28, 2024
14 checks passed
@congqixia congqixia deleted the cp24/31622 branch April 1, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants