Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong behavior of CurrentTargetFirst/NextTargetFirst in target manager #31378

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Mar 18, 2024

issue: #31162
pr: #31379

when give scope CurrentTargetFirst/NextTargetFirst, it's expected to scan both current and next target.

This PR fixed wrong behavior of CurrentTargetFirst/NextTargetFirst in target manager, which may cause unexpected task generated, and load collection may stuck forever due to dirty leader view.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 18, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Mar 18, 2024
Copy link
Contributor

mergify bot commented Mar 18, 2024

@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Mar 18, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added this to the 2.4.0 milestone Mar 18, 2024
@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Mar 18, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 18, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the fix_target_manager24 branch from d8801fa to 31b6fa0 Compare March 18, 2024 23:55
@sre-ci-robot sre-ci-robot removed the lgtm label Mar 18, 2024
Copy link
Contributor

mergify bot commented Mar 19, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 99.03846% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.05%. Comparing base (3254a14) to head (31b6fa0).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              2.4   #31378     +/-   ##
=========================================
  Coverage   81.05%   81.05%             
=========================================
  Files         980      980             
  Lines      144653   143441   -1212     
=========================================
- Hits       117248   116270    -978     
+ Misses      23529    23278    -251     
- Partials     3876     3893     +17     
Files Coverage Δ
internal/querycoordv2/meta/target_manager.go 87.14% <99.03%> (+3.51%) ⬆️

... and 174 files with indirect coverage changes

@mergify mergify bot added kind/bug Issues or changes related a bug ci-passed labels Mar 19, 2024
@czs007
Copy link
Collaborator

czs007 commented Mar 19, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit f4449d4 into milvus-io:2.4 Mar 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants