-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Wrong behavior of CurrentTargetFirst/NextTargetFirst in target manager #31378
Conversation
@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
@weiliu1031 E2e jenkins job failed, comment |
…anager Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
d8801fa
to
31b6fa0
Compare
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #31378 +/- ##
=========================================
Coverage 81.05% 81.05%
=========================================
Files 980 980
Lines 144653 143441 -1212
=========================================
- Hits 117248 116270 -978
+ Misses 23529 23278 -251
- Partials 3876 3893 +17
|
/lgtm |
issue: #31162
pr: #31379
when give scope CurrentTargetFirst/NextTargetFirst, it's expected to scan both current and next target.
This PR fixed wrong behavior of CurrentTargetFirst/NextTargetFirst in target manager, which may cause unexpected task generated, and load collection may stuck forever due to dirty leader view.