[Bug]: Compiler error in link stage

[xlxie]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Error log:

Building Milvus ...
# github.com/milvus-io/milvus/internal/indexnode
internal/indexnode/../core/output/lib/libmilvus_indexbuilder.so: undefined reference to `dgesvd_'
internal/indexnode/../core/output/lib/libmilvus_indexbuilder.so: undefined reference to `dsyev_'
internal/indexnode/../core/output/lib/libmilvus_indexbuilder.so: undefined reference to `sgeqrf_'
internal/indexnode/../core/output/lib/libmilvus_indexbuilder.so: undefined reference to `sorgqr_'
internal/indexnode/../core/output/lib/libmilvus_indexbuilder.so: undefined reference to `sgesvd_'
collect2: error: ld returned 1 exit status
# github.com/milvus-io/milvus/internal/querynode
internal/querynode/../core/output/lib/libmilvus_segcore.so: undefined reference to `sgeqrf_'
internal/querynode/../core/output/lib/libmilvus_segcore.so: undefined reference to `sgesvd_'
internal/querynode/../core/output/lib/libmilvus_segcore.so: undefined reference to `dsyev_'
internal/querynode/../core/output/lib/libmilvus_segcore.so: undefined reference to `dgesvd_'
internal/querynode/../core/output/lib/libmilvus_segcore.so: undefined reference to `sorgqr_'

Expected Behavior

Compile succeeded

Steps To Reproduce

Install the dependencies and run make.

Environment

- Milvus version: 2.0.0-rc7
- Deployment mode(standalone or cluster): NaN
- SDK version(e.g. pymilvus v2.0.0rc2): NaN
- OS(Ubuntu or CentOS): Redhat
- CPU/Memory: Intel(R) Xeon(R) Platinum 8163 CPU @ 2.50GHz
- GPU: NaN
- Others:

Anything else?

I found that when building libmilvus_segcore.so and libmilvus_indexbuilder.so, compiler flag -llapack is missed. I added it manually and the compiling succeeded.

[xiaofan-luan]

Thanks xlxie for the issue, can you make a pull request to fix the issue?

[xlxie]

Thanks xlxie for the issue, can you make a pull request to fix the issue?

No problem. Please allow me to spend sometime to learn about how to contribute to this project.

[xiaofan-luan]

Thanks xlxie for the issue, can you make a pull request to fix the issue?

No problem. Please allow me to spend sometime to learn about how to contribute to this project.

See contributing.md, that would help you a lot about DCO and git flow

[yanliang567]

/unassign
/assign @xlxie

[XuanYang-cn]

maybe caused by :

Lapack is not included in the openblas library

refs:

facebookresearch/faiss#307

facebookresearch/faiss#15

Hopefully helpful

[xlxie]

Thanks xlxie for the issue, can you make a pull request to fix the issue?

No problem. Please allow me to spend sometime to learn about how to contribute to this project.

See contributing.md, that would help you a lot about DCO and git flow

I just found the root cause.

In my build, I use blas + lapack, we need to add -lblas and -llapack whenever we use blas.

In the milvus official build, milvus uses openblas. Openblas includes the functions of both blas and lapack. As such, -lopenblas = -lblas + -llapack.

It is no longer a issue if I use openblas in this build. As such, it is closed.