Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: channel unbalance during stopping balance progress #38970

Open
1 task done
weiliu1031 opened this issue Jan 3, 2025 · 0 comments
Open
1 task done

[Bug]: channel unbalance during stopping balance progress #38970

weiliu1031 opened this issue Jan 3, 2025 · 0 comments
Assignees
@weiliu1031
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@weiliu1031
Copy link
Contributor

weiliu1031 commented Jan 3, 2025 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 2.4, 2.5 and master
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

cause the stopping balance channel still use the row_count_based policy, which may causes channel unbalance in multi-collection case.

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@weiliu1031 weiliu1031 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 3, 2025
@weiliu1031 weiliu1031 mentioned this issue Jan 3, 2025
Merged
@bigsheeper bigsheeper mentioned this issue Jan 3, 2025
Merged
czs007 pushed a commit that referenced this issue Jan 3, 2025
@bigsheeper @weiliu1031
fix: [10kcp] channel unbalance during stopping balance progress (#38972)
f5f4fed 
issue: #38970,
#37630

cause the stopping balance channel still use the row_count_based policy,
which may causes channel unbalance in multi-collection case.

This PR impl a score based stopping balance channel policy.

pr: #38971

Signed-off-by: bigsheeper <[email protected]>
Co-authored-by: Wei Liu <[email protected]>
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 3, 2025
@yanliang567 yanliang567 assigned weiliu1031 and unassigned yanliang567 Jan 3, 2025
sre-ci-robot pushed a commit that referenced this issue Jan 13, 2025
@weiliu1031
fix: channel unbalance during stopping balance progress (#38971)
cc5d593 
issue: #38970
cause the stopping balance channel still use the row_count_based policy,
which may causes channel unbalance in multi-collection case.

This PR impl a score based stopping balance channel policy.

Signed-off-by: Wei Liu <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Jan 13, 2025
@weiliu1031
fix: channel unbalance during stopping balance progress (milvus-io#38971
a748837 
)

issue: milvus-io#38970
cause the stopping balance channel still use the row_count_based policy,
which may causes channel unbalance in multi-collection case.

This PR impl a score based stopping balance channel policy.

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this issue Jan 13, 2025
Merged
sre-ci-robot pushed a commit that referenced this issue Jan 14, 2025
@weiliu1031
fix: channel unbalance during stopping balance progress (#38971) (#39200
5199415 
)

issue: #38970
pr: #38971
cause the stopping balance channel still use the row_count_based policy,
which may causes channel unbalance in multi-collection case.

This PR impl a score based stopping balance channel policy.

Signed-off-by: Wei Liu <[email protected]>
gifi-siby pushed a commit to gifi-siby/milvus that referenced this issue Jan 16, 2025
@weiliu1031 @gifi-siby
fix: channel unbalance during stopping balance progress (milvus-io#38971
1b586f5 
)

issue: milvus-io#38970
cause the stopping balance channel still use the row_count_based policy,
which may causes channel unbalance in multi-collection case.

This PR impl a score based stopping balance channel policy.

Signed-off-by: Wei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weiliu1031 weiliu1031

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yanliang567 @weiliu1031