Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: creating huge thread when using inverted text index #37851

Closed
1 task done
chyezh opened this issue Nov 20, 2024 · 2 comments
Closed
1 task done

[Bug]: creating huge thread when using inverted text index #37851

chyezh opened this issue Nov 20, 2024 · 2 comments
Assignees
@chyezh @yanliang567
Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@chyezh
Copy link
Contributor

chyezh commented Nov 20, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master-714421997c01b90fd0c7992ece390428c98fb9f9
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

  • Huge thread creation when running test_search_vector_with_text_match_filter and test_query_vector_with_text_match_filter`
  • Make CI slowly and timeout.

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@chyezh chyezh added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 20, 2024
@chyezh chyezh changed the title [Bug]: Huge thread creation when using inverted text index [Bug]: creating huge thread when using inverted text index Nov 20, 2024
@chyezh chyezh mentioned this issue Nov 20, 2024
Merged
@chyezh
Copy link
Contributor Author

chyezh commented Nov 20, 2024

/assign

@chyezh chyezh mentioned this issue Nov 20, 2024
Closed
1 task
sre-ci-robot pushed a commit that referenced this issue Nov 20, 2024
@chyezh
fix: use global pool but not dedicated pool for every index (#37852)
f3a36f8 
issue: #37851

- make a global thread pool at tantivy temporally.
- set 1 but not 4 threads for inverted text index.

Signed-off-by: chyezh <[email protected]>
@chyezh
Copy link
Contributor Author

chyezh commented Nov 20, 2024

should be fixed.

@chyezh chyezh closed this as completed Nov 20, 2024
This was referenced Nov 22, 2024
Merged
Merged
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 25, 2024
@chyezh
enhance: make all index operation async scheduled by tokio (#37946)
fbb68ca 
issue: #37851
related pr: milvus-io/tantivy#3

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Nov 25, 2024
@chyezh
enhance: make all index operation async scheduled by tokio (#37958)
95a2ea6 
issue: #37851
related pr: milvus-io/tantivy#3
pr: #37946

Signed-off-by: chyezh <[email protected]>
JsDove pushed a commit to JsDove/milvus that referenced this issue Nov 26, 2024
@chyezh @JsDove
fix: use global pool but not dedicated pool for every index (milvus-i…
41625d3 
…o#37852)

issue: milvus-io#37851

- make a global thread pool at tantivy temporally.
- set 1 but not 4 threads for inverted text index.

Signed-off-by: chyezh <[email protected]>
JsDove pushed a commit to JsDove/milvus that referenced this issue Nov 26, 2024
@chyezh @JsDove
enhance: make all index operation async scheduled by tokio (milvus-io…
6b8af83 
…#37946)

issue: milvus-io#37851
related pr: milvus-io/tantivy#3

Signed-off-by: chyezh <[email protected]>
@chyezh chyezh mentioned this issue Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chyezh chyezh

@yanliang567 yanliang567

Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chyezh @yanliang567