Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: metric type not correctly propagated to knowhere when using group by #34730

Closed
1 task done
zhengbuqian opened this issue Jul 16, 2024 · 3 comments
Closed
1 task done

[Bug]: metric type not correctly propagated to knowhere when using group by #34730

zhengbuqian opened this issue Jul 16, 2024 · 3 comments
Assignees
@zhengbuqian
Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@zhengbuqian
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Environment

No response

Current Behavior

when using groupby, even if we have set metric type to other metrics in SDK, knowhere will always see L2.

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@zhengbuqian zhengbuqian added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 16, 2024
@zhengbuqian zhengbuqian self-assigned this Jul 16, 2024
This was referenced Jul 16, 2024
Merged
Merged
@zhengbuqian
Copy link
Collaborator Author

this is currently blocking #34700.

@xiaofan-luan
Copy link
Collaborator

do we need to backport to 2.3?

sre-ci-robot pushed a commit that referenced this issue Jul 16, 2024
@zhengbuqian
correctly set search params when using knowhere iterator (#34732)
dfb4158 
issue: #34730
pr: #34731

Signed-off-by: Buqian Zheng <[email protected]>
@zhengbuqian
Copy link
Collaborator Author

do we need to backport to 2.3?

No we don't. Usage of KW Iterator and GroupBy is introduced in 2.4

sre-ci-robot pushed a commit that referenced this issue Jul 17, 2024
@zhengbuqian
fix: correctly set search params when using knowhere iterator (#34731)
aa5418a 
issue: #34730

Signed-off-by: Buqian Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhengbuqian zhengbuqian

Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhengbuqian @xiaofan-luan