Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: e2e case test_compact_during_insert is not stable #34637

Closed
1 task done
congqixia opened this issue Jul 12, 2024 · 2 comments
Closed
1 task done

[Bug]: e2e case test_compact_during_insert is not stable #34637

congqixia opened this issue Jul 12, 2024 · 2 comments
Assignees
Labels
ci/bug ci/e2e kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

congqixia commented Jul 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 531092c
- Deployment mode(standalone or cluster): both
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

e2e case test_compact_during_insert is not stable

Expected Behavior

e2e case shall pass stably

Steps To Reproduce

No response

Milvus Log

[2024-07-12T04:15:07.918Z]         # search

[2024-07-12T04:15:07.918Z]         search_res, _ = collection_w.search([df[ct.default_float_vec_field_name][0]],

[2024-07-12T04:15:07.918Z]                                             ct.default_float_vec_field_name,

[2024-07-12T04:15:07.918Z]                                             ct.default_search_params, ct.default_limit)

[2024-07-12T04:15:07.918Z] >       assert len(search_res[0]) == ct.default_limit

[2024-07-12T04:15:07.918Z] E       AssertionError: assert 9 == 10

[2024-07-12T04:15:07.918Z] E        +  where 9 = len(['id: 4000, distance: 0.9999669194221497, entity: {}', 'id: 1776, distance: 0.8461944460868835, entity: {}', 'id: 1563, distance: 0.8287100195884705, entity: {}', 'id: 5415, distance: 0.8226537108421326, entity: {}', 'id: 2236, distance: 0.8202782869338989, entity: {}', 'id: 523, distance: 0.8194977641105652, entity: {}', 'id: 1070, distance: 0.8174188137054443, entity: {}', 'id: 1955, distance: 0.8171544671058655, entity: {}', 'id: 976, distance: 0.8167256712913513, entity: {}'])

[2024-07-12T04:15:07.918Z] E        +  and   10 = ct.default_limit

[2024-07-12T04:15:07.918Z] 

[2024-07-12T04:15:07.918Z] testcases/test_compaction.py:1209: AssertionError

Anything else?

https://jenkins.milvus.io:18080/blue/organizations/jenkins/Milvus%20HA%20CI/detail/PR-34632/1/pipeline

@congqixia congqixia added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 12, 2024
@congqixia congqixia added triage/accepted Indicates an issue or PR is ready to be actively worked on. ci/e2e ci/bug and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 12, 2024
@bigsheeper
Copy link
Contributor

bigsheeper commented Jul 12, 2024

I think this case is normal. This case inserted 6000 entries, then built an ivfpq index (nlist=128), search with nprob=32, and top 10. When ivf clustering is uneven, getting only 9 results is possible.

@congqixia
Copy link
Contributor Author

congqixia commented Jul 15, 2024

@bigsheeper after some confirmation with Knowhere team. It's possible to get an empty bucket when doing KMeans clustering but the chance is extremely low. It is almost impossible to meet 32 buckets having only 9 candidates. Even then situation is met, Knowhere would skip empty buckets. It looks that some bug still exists here.
/cc @XuanYang-cn

congqixia added a commit to congqixia/milvus that referenced this issue Jul 15, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Jul 15, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Jul 15, 2024
sre-ci-robot pushed a commit that referenced this issue Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/bug ci/e2e kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants