Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Only search output vector is performed, but the monitor sees search and query. #34601

Closed
1 task done
elstic opened this issue Jul 11, 2024 · 3 comments
Closed
1 task done

[Bug]: Only search output vector is performed, but the monitor sees search and query. #34601

elstic opened this issue Jul 11, 2024 · 3 comments
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
2.4.7

Comments

@elstic
Copy link
Contributor

elstic commented Jul 11, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 2.3, 2.4 & master
- Deployment mode(standalone or cluster):all
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

When I do a seach output vector, the monitor sees that both search and query are going on
image

Expected Behavior

If I do a search output vector, the monitor only displays the search and not the search and query.

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@elstic elstic added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2024
@elstic elstic assigned yanliang567 and congqixia and unassigned yanliang567 Jul 11, 2024
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2024
@yanliang567 yanliang567 added this to the 2.4.6 milestone Jul 11, 2024
@yanliang567
Copy link
Contributor

internal re-query should not be counted into metrics...

@congqixia
Copy link
Contributor

master & 2.4 already fixed
doing some code refinement and cherry-pick

congqixia added a commit to congqixia/milvus that referenced this issue Jul 12, 2024
@congqixia
enhance: Use unified requery flag when set metrics
54d29f5 
See also milvus-io#34601

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Jul 12, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 15, 2024
@congqixia
enhance: Use unified requery flag when set metrics (#34632)
b5225df 
See also #34601

Signed-off-by: Congqi Xia <[email protected]>
@yanliang567 yanliang567 modified the milestones: 2.4.6, 2.4.7 Jul 19, 2024
@elstic
Copy link
Contributor Author

elstic commented Jul 29, 2024

issue fixed.
verify image: 2.4 and master's latest image

@elstic elstic closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
2.4.7
Development

No branches or pull requests
3 participants
@elstic @yanliang567 @congqixia