Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Map grow takes many proxy cpu on large topk #32870

Closed
1 task done
xiaofan-luan opened this issue May 8, 2024 · 0 comments · Fixed by #32871
Closed
1 task done

[Enhancement]: Map grow takes many proxy cpu on large topk #32870

xiaofan-luan opened this issue May 8, 2024 · 0 comments · Fixed by #32871
Assignees
@xiaofan-luan
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@xiaofan-luan
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

image

when topk is 1000, proxy reduce spend many cpu on map grow, idset need to preallocate size to avoid hash grow

Why is this needed?

No response

Anything else?

No response
@xiaofan-luan xiaofan-luan added the kind/enhancement Issues or changes related to enhancement label May 8, 2024
@xiaofan-luan xiaofan-luan self-assigned this May 8, 2024
@xiaofan-luan xiaofan-luan mentioned this issue May 8, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 13, 2024
@xiaofan-luan
enhance: improve reduce performance on very large topk (#32871)
230c88b 
fix #32870
reduce cpu usage for reduce on large k

Signed-off-by: xiaofanluan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaofan-luan xiaofan-luan

Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhance: improve reduce performance on very large topk xiaofan-luan/milvus
1 participant
@xiaofan-luan