Skip to content

Commit

Permalink
fix: repeated error code in milvus and segcore (#37359)
Browse files Browse the repository at this point in the history
issue: #37357

Signed-off-by: chyezh <[email protected]>
  • Loading branch information
chyezh authored Nov 5, 2024
1 parent b83b376 commit 9a0e1c8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
12 changes: 6 additions & 6 deletions internal/core/src/common/EasyAssert.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ enum ErrorCode {
MemAllocateFailed = 2034,
MemAllocateSizeNotMatch = 2035,
MmapError = 2036,
OutOfRange = 2037,
GcpNativeError = 2038,
KnowhereError = 2100,
// timeout or cancel related
FollyOtherException = 2037,
FollyCancel = 2038,
OutOfRange = 2039,
GcpNativeError = 2040,

// timeout or cancel related.
FollyOtherException = 2200,
FollyCancel = 2201
KnowhereError = 2099
};
namespace impl {
void
Expand Down
7 changes: 5 additions & 2 deletions pkg/util/merr/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,11 @@ var (
ErrSegcore = newMilvusError("segcore error", 2000, false)
ErrSegcoreUnsupported = newMilvusError("segcore unsupported error", 2001, false)
ErrSegcorePretendFinished = newMilvusError("segcore pretend finished", 2002, false)
ErrSegcoreFollyOtherException = newMilvusError("segcore folly other exception", 2200, false) // throw from segcore.
ErrSegcoreFollyCancel = newMilvusError("segcore Future was canceled", 2201, false) // throw from segcore.
ErrSegcoreFollyOtherException = newMilvusError("segcore folly other exception", 2037, false) // throw from segcore.
ErrSegcoreFollyCancel = newMilvusError("segcore Future was canceled", 2038, false) // throw from segcore.
ErrSegcoreOutOfRange = newMilvusError("segcore out of range", 2039, false) // throw from segcore.
ErrSegcoreGCPNativeError = newMilvusError("segcore GCP native error", 2040, false) // throw from segcore.
KnowhereError = newMilvusError("knowhere error", 2099, false) // throw from segcore.

// Do NOT export this,
// never allow programmer using this, keep only for converting unknown error to milvusError
Expand Down

0 comments on commit 9a0e1c8

Please sign in to comment.