Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexOutOfBoundsException #790

Closed
wants to merge 2 commits into from
Closed

IndexOutOfBoundsException #790

wants to merge 2 commits into from

Conversation

zsinba
Copy link

@zsinba zsinba commented Mar 5, 2024

"Fix IndexOutOfBoundsException in getRowRecords method by ensuring topK value does not exceed idScore length"

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zsinba
To complete the pull request process, please assign yelusion2 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yelusion2 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan
Copy link
Contributor

@zsinba
thanks for the contribution.
the pr looks good to me.
You will need to sign DCO before this pr merge.

@mergify mergify bot added the ci-passed label Mar 8, 2024
@yhmo
Copy link
Contributor

yhmo commented Mar 12, 2024

I have merged the code changes to #800 and #801. Since this pr didn't pass DCO check, I closed it. Thanks for pointing out this problem and providing the fix!

@yhmo yhmo closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants