Resolve Netty version conflicts using netty-shaded #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @yelusion2 |
Signed-off-by: 柯榕滨(ruby.ke) <[email protected]>
CaptainRuby
force-pushed
the
netty_shaded
branch
from
6cc8d6e to
1677dbd
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CaptainRuby The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the milvus-java-sdk within a Spring project, I encountered multiple compatibility issues with different versions of Netty. Regardless of which version of Netty was prioritized, runtime errors occurred. The only viable solution was to use a shaded version of Netty. This issue was not present in older versions of the milvus-java-sdk, which used a shaded version of Netty. It's unclear why the shading was removed from the pom file in later versions. Consequently, upgrading to the latest version of the milvus-java-sdk led to the aforementioned problems.