Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support hints param #1231

Closed
wants to merge 1 commit into from

Conversation

chasingegg
Copy link

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg
To complete the pull request process, please assign yelusion2 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yelusion2 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chasingegg
Copy link
Author

@yhmo will help on search_params refactoring, after that we do not need to change anything in sdk to support new params like hints.
/hold

@yhmo
Copy link
Contributor

yhmo commented Dec 16, 2024

close this pr. I will submit another pr to refine the searchParams

@yhmo yhmo closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants