Supports filling elements through templates for expression #1144
Conversation
Signed-off-by: yhmo <[email protected]>
Signed-off-by: cai.zhang <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xiaocai2333 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| DataType lastType = DataType.UNRECOGNIZED; | ||
| boolean sameType = true; | ||
| for (Object obj : array) { | ||
| TemplateValue tv = deduceTemplateValue(obj); | ||
| builder.addArray(tv); | ||
| if (lastType == DataType.UNRECOGNIZED) { | ||
| lastType = tv.getType(); | ||
| } else if (lastType != tv.getType()) { | ||
| sameType = false; | ||
| } | ||
| DataType arrayType = sameType ? lastType : DataType.JSON; | ||
| builder.setElementType(arrayType); | ||
| builder.setSameType(sameType); | ||
| } |
There was a problem hiding this comment.
| DataType lastType = DataType.UNRECOGNIZED; | |
| boolean sameType = true; | |
| for (Object obj : array) { | |
| TemplateValue tv = deduceTemplateValue(obj); | |
| builder.addArray(tv); | |
| if (lastType == DataType.UNRECOGNIZED) { | |
| lastType = tv.getType(); | |
| } else if (lastType != tv.getType()) { | |
| sameType = false; | |
| } | |
| DataType arrayType = sameType ? lastType : DataType.JSON; | |
| builder.setElementType(arrayType); | |
| builder.setSameType(sameType); | |
| } | |
| DataType lastType = DataType.UNRECOGNIZED; | |
| boolean sameType = true; | |
| for (Object obj : array) { | |
| TemplateValue tv = deduceTemplateValue(obj); | |
| builder.addArray(tv); | |
| if (sameType && lastType != DataType.UNRECOGNIZED && lastType != tv.getType()) { | |
| sameType = false; | |
| } | |
| lastType = tv.getType(); | |
| } | |
| DataType arrayType = sameType ? lastType : DataType.JSON; | |
| builder.setElementType(arrayType); | |
| builder.setSameType(sameType); |
| return builder.build(); | ||
| } | ||
|
|
||
| public static TemplateValue deduceTemplateValue(Object value) { |
There was a problem hiding this comment.
nit: I prefer long method names that convey the exact action, maybe deduceAndCreateTemplateValue
| DataType elementType = DataType.None; | ||
| int i = 0; | ||
|
|
||
| for (Object element : (List<?>) value) { |
|
/close |
|
@xiaocai2333: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.