Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove the logic to set replica_number=1 by default #780

Merged

Conversation

weiliu1031
Copy link
Contributor

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 July 2, 2024 10:28
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 2, 2024
@weiliu1031 weiliu1031 force-pushed the remove_set_replica_number branch from 18288da to 4c6c92a Compare July 2, 2024 11:20
@weiliu1031 weiliu1031 force-pushed the remove_set_replica_number branch from 4c6c92a to 7b63383 Compare July 4, 2024 00:05
@mergify mergify bot added the ci-passed auto merge needed label label Jul 4, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jul 4, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Jul 4, 2024
@sre-ci-robot sre-ci-robot merged commit 6067806 into milvus-io:master Jul 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants