Target net462 for gRPC WinHttpHandler support #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found that GitHub Actions seems to support Windows Server 2022. Maybe we can try testing it with .NET Framework in GitHub Actions? |
minhhieugma
pushed a commit
to minhhieugma/milvus-sdk-csharp
that referenced
this pull request
Sep 1, 2023
Sure, but you'd need to deal with spinning up Milvus on Windows in CI, which I'm not sure is that easy... I did do some manual testing locally to at least confirm that this working. |
|
Yes, it is not easy to run Milvus on Windows. Milvus-lite provides an option to run Milvus using a Python environment. Let me try this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies usage for .NET Framework users, where WinHttpHandler needs to be used. This PR was recently merged, which makes the net462 version of Grpc.Net.Client automatically use WinHttpHandler; having Milvus.Client target net462 takes advantage of that as well.
/cc @stephentoub