Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enable setting properties during database creation (#295) #296

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Jul 5, 2024

@sre-ci-robot sre-ci-robot requested review from nameczz and yhmo July 5, 2024 03:59
@mergify mergify bot added the dco-passed DCO check passed. label Jul 5, 2024
Copy link

mergify bot commented Jul 5, 2024

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”)

Copy link
Collaborator

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7a65871 into milvus-io:2.4 Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants