Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility on MdModal #77

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

kajsaeggum
Copy link
Contributor

Describe your changes

Added functionality to MdModal to fulfill the accessibility requirements of a dialog:

  • role "dialog"
  • aria-modal "true"
  • aria-label describing the dialog contents
  • allow closing of the modal using Escape-key

Also added forwardRef to MdLink, to be able to focus on a link-component. Specifically to be able to bring focus back to the correct place after closing a MdModal.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@kajsaeggum kajsaeggum requested a review from a team as a code owner January 23, 2024 16:21
@kajsaeggum kajsaeggum merged commit 7eb1bb8 into main Jan 24, 2024
@kajsaeggum kajsaeggum deleted the feature/accessibilityPropsOnModal branch January 24, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants