Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/props on form elements #62

Merged
merged 9 commits into from
Dec 21, 2023
Merged

Conversation

kajsaeggum
Copy link
Contributor

@kajsaeggum kajsaeggum commented Dec 20, 2023

Describe your changes

  • Added properties to MdInput for type=number: min, max and step for controlling allowed data. And adjusted type of value-property.
  • Added forwardRef to MdMultiSelect to be able to reference it from outside and focus on it, just like the other form components. (Nothing else is changed even though it looks like it in the diff-view of github)
  • Also fixed error in focus trap on MdModal when there are disabled elements in the modal

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@kajsaeggum kajsaeggum requested a review from a team as a code owner December 20, 2023 15:07
Copy link
Contributor

@aurorascharff aurorascharff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Må oppdatere branchen fra main og bumpe version pånytt etterpå.

@kajsaeggum kajsaeggum merged commit 6fe80b8 into main Dec 21, 2023
@aurorascharff aurorascharff deleted the feature/propsOnFormElements branch December 21, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants