Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-hidden and aria-labels, make radiogroup and checkboxgroup fieldsets #52

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Add aria-hidden and aria-labels, make radiogroup and checkboxgroup fieldsets #52

merged 5 commits into from
Dec 14, 2023

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented Dec 8, 2023 •
edited
Loading

Describe your changes

Add aria-labels and aria-hidden to icons, make checkboxgroup and radiogroup fieldsets.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@aurorascharff aurorascharff changed the title add aria hidden and aria-labels Add aria hidden and aria-labels Dec 8, 2023
@aurorascharff aurorascharff changed the title Add aria hidden and aria-labels Add aria hidden and aria-labels to icons and icon buttons Dec 11, 2023
@aurorascharff aurorascharff marked this pull request as ready for review December 11, 2023 13:01
@aurorascharff aurorascharff requested a review from a team as a code owner December 11, 2023 13:01
@aurorascharff aurorascharff changed the title Add aria hidden and aria-labels to icons and icon buttons Add aria-hidden and aria-labels to icons and icon buttons Dec 11, 2023
@aurorascharff aurorascharff changed the title Add aria-hidden and aria-labels to icons and icon buttons Add aria-hidden and aria-labels, make radiogroup and checkboxgroup fieldsets Dec 13, 2023
@aurorascharff aurorascharff merged commit e31a73d into main Dec 14, 2023
@aurorascharff aurorascharff deleted the various-a11y-fixes branch December 14, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajsaeggum kajsaeggum kajsaeggum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurorascharff @kajsaeggum