Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a11y to MdAccordion, increase MdInput suffix contrast #51

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Add a11y to MdAccordion, increase MdInput suffix contrast #51

merged 4 commits into from
Dec 8, 2023

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented Dec 8, 2023 •
edited
Loading

Describe your changes

  • Add accessibility features to MdAccordion
  • Increase contrast on MdInput suffix
  • Let MdAccordionItem close text be definable

Asked designers to update design system in Figma with the higher contrast input suffix.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@aurorascharff aurorascharff marked this pull request as ready for review December 8, 2023 12:04
@aurorascharff aurorascharff requested a review from a team as a code owner December 8, 2023 12:04
@aurorascharff aurorascharff changed the title Add a11y to MdAccordion, increase MdInput contrast Add a11y to MdAccordion, increase MdInput suffix contrast Dec 8, 2023
ohp-inmeta
ohp-inmeta approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@ohp-inmeta ohp-inmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut. Bare et obs om at alle design-, farge, og UX-endringer skal innom Martine på design før vi endrer noe. Denne lille fargeendringen trenger ikke det, men dersom det er litt større endringer må design involveres :)

@aurorascharff
Copy link
Contributor Author

Takk for påminnelsen, @ohp-inmeta !

@aurorascharff aurorascharff merged commit 9169869 into main Dec 8, 2023
@aurorascharff aurorascharff deleted the accordion-a11y branch December 8, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohp-inmeta ohp-inmeta ohp-inmeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurorascharff @ohp-inmeta