Dont override md-classes when adding className prop to button and link #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changed order of applied props to button and link elements. Otherwise adding a className property when using MdLink or MdButton component will effectively remove the internal classes that style them correctly.
Also made sure that the resulting classes added on the element include both the internal classes and any applied from the outside, so that it is possible to further style the component where it is being used.
NB: If allowing users of the component library to extend styling in this way is accepted, the same logic should be added to all the components, not just MdLink and MdButton as I've done here.
Checklist before requesting a review
stories
-folder?packages/react/index.tsx
?packages/css/index.css
?