Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add type button to help button #28

Merged
merged 2 commits into from
Sep 27, 2023
Merged

fix: add type button to help button #28

merged 2 commits into from
Sep 27, 2023

Conversation

aurorascharff
Copy link
Contributor

Describe your changes

When MdHelpButton is used inside a form, clicking the help text button triggers a form submission since it does not have a button type. Add type="button".

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@aurorascharff aurorascharff requested review from Jaanesen and a team as code owners September 27, 2023 06:22
crolsson
crolsson approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@crolsson crolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohp-inmeta ohp-inmeta merged commit edf6b4c into miljodir:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crolsson crolsson crolsson approved these changes

@Jaanesen Jaanesen Awaiting requested review from Jaanesen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aurorascharff @crolsson @ohp-inmeta