Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/storybook v8 #202

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Feature/storybook v8 #202

merged 3 commits into from
Dec 6, 2024

Conversation

ohp-inmeta
Copy link
Contributor

@ohp-inmeta ohp-inmeta commented Dec 5, 2024

Describe your changes

Upgrade storybook to v8
Added addon for a11y testing

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@ohp-inmeta ohp-inmeta requested a review from a team as a code owner December 5, 2024 20:45
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Please set a versioning label of either major, minor, or patch to the pull request.

@ohp-inmeta
Copy link
Contributor Author

Storybook v8 💯
Updated to 8.4.6, then 2 hours later 8.4.7 came out, so updated again :D

Not sure if this qualifies as a major or minor version, thoughts?

@aurorascharff
Copy link
Contributor

If nothing changes for the users of the component library it would not be a major, right?
Remember to set versioning label.

@aurorascharff aurorascharff linked an issue Dec 6, 2024 that may be closed by this pull request
Copy link
Contributor

@aurorascharff aurorascharff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det var jo faktisk ikke så mange endringer! I storybook 6-7 var det veldig mange APIer som måtte endres. Godt jobba :)

},
},
],

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en del tomme linjer som kan fjernes i denne filen, antar det er pga autogenerert config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, det, pluss at jeg liker å ha litt rom mellom parametere, lettere å lese :P

override package version for parse-url as a critical dependency
@ohp-inmeta ohp-inmeta linked an issue Dec 6, 2024 that may be closed by this pull request
@ohp-inmeta ohp-inmeta merged commit cf5b0a7 into main Dec 6, 2024
3 checks passed
@ohp-inmeta ohp-inmeta deleted the feature/storybook-v8 branch December 6, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critital security vulnerabilities Upgrade Storybook to version 8
2 participants