-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/storybook v8 #202
Feature/storybook v8 #202
Conversation
kinda works
Please set a versioning label of either |
Storybook v8 💯 Not sure if this qualifies as a major or minor version, thoughts? |
If nothing changes for the users of the component library it would not be a major, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det var jo faktisk ikke så mange endringer! I storybook 6-7 var det veldig mange APIer som måtte endres. Godt jobba :)
.storybook/main.ts
Outdated
}, | ||
}, | ||
], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en del tomme linjer som kan fjernes i denne filen, antar det er pga autogenerert config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja, det, pluss at jeg liker å ha litt rom mellom parametere, lettere å lese :P
override package version for parse-url as a critical dependency
Describe your changes
Upgrade storybook to v8
Added addon for a11y testing
Checklist before requesting a review
major
,minor
orpatch
)stories
-folder?packages/react/index.tsx
?packages/css/index.css
?