Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Radio button click area is not covering the whole button circle #195

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: Radio button click area is not covering the whole button circle #195

merged 2 commits into from
Nov 12, 2024

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented Nov 12, 2024 •
edited
Loading

Describe your changes

The radio button click area does not cover the whole toggle button circle - fix this.

Users' feedback was that certain parts of the radio button were not working, and it was annoying to use.

image

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@aurorascharff aurorascharff changed the title fix: radio button click area is not covering the whole toggle button circle fix: Radio button click area is not covering the whole toggle button circle Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff aurorascharff marked this pull request as ready for review November 12, 2024 13:05
@aurorascharff aurorascharff requested a review from a team as a code owner November 12, 2024 13:05
@aurorascharff aurorascharff changed the title fix: Radio button click area is not covering the whole toggle button circle fix: Radio button click area is not covering the whole button circle Nov 12, 2024
@aurorascharff aurorascharff linked an issue Nov 12, 2024 that may be closed by this pull request
Brukere opplever at det er vanskelig å trykke på radiobuttons #194
Closed
@aurorascharff aurorascharff merged commit 780945d into main Nov 12, 2024
3 of 4 checks passed
@aurorascharff aurorascharff deleted the fix-radiobutton-click branch November 12, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajsaeggum kajsaeggum kajsaeggum approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brukere opplever at det er vanskelig å trykke på radiobuttons
2 participants
@aurorascharff @kajsaeggum