Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aria-hidden was applied to the wrong div inside MdTooltip #172

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented Sep 11, 2024

Describe your changes

Previously aria-hidden had been applied to the children the tooltip is wrapping content rather than the tooltip content itself. This caused errors in the console when the focus was trying target to the content.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@aurorascharff aurorascharff requested a review from a team as a code owner September 11, 2024 13:14
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff aurorascharff merged commit 674fdbc into main Sep 11, 2024
4 of 5 checks passed
@aurorascharff aurorascharff deleted the aria-hidden-tooltip branch September 11, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants