Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/malin 286 selectbox changes #17

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

ohp-inmeta
Copy link
Contributor

Describe your changes

  • The dropdown now overlays content below, in stead of pushing it down
  • When select is open, you can press a letter on the keyboard and it will focus on the first element in the dropdown that start with this letter.

Checklist before requesting a review

  • I have performed a self-review and test of my code

- The dropdown now overlays content below, in stead of pushing it down
- When select is open, you can press a letter on the keyboard and it will focus on the first element in the dropdown that start with this letter.
@ohp-inmeta ohp-inmeta requested review from a team and Jaanesen as code owners June 12, 2023 13:16
}
});

const onKeyDown = (e: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kunne kanskje utvidet til å ta imot piltast opp og ned for å kunne gå opp og ned i listen også uten å bruke musepekeren? (Ikke must have akkurat nå)

Copy link
Contributor

@Jaanesen Jaanesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut 🥳🙌🪂

@ohp-inmeta ohp-inmeta merged commit 29ec931 into main Jun 13, 2023
@ohp-inmeta ohp-inmeta deleted the feature/MALIN-286-SelectboxChanges branch June 13, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants