Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce theme types in all themed components #166

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Enforce theme types in all themed components #166

merged 2 commits into from
Sep 10, 2024

Conversation

aurorascharff
Copy link
Contributor

Describe your changes

Enforce only specific strings to components with the "theme" property.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@aurorascharff aurorascharff marked this pull request as ready for review September 10, 2024 07:18
@aurorascharff aurorascharff requested a review from a team as a code owner September 10, 2024 07:18
@github-actions GitHub Actions
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff
Copy link
Contributor Author

@kajsaeggum Du kan si dette er breaking dersom noen har brukt en ugyldig verdi. Men det skal de forhåpentligvis ikke ha gjort, da. Hva tenker du?

@kajsaeggum
Copy link
Contributor

@kajsaeggum Du kan si dette er breaking dersom noen har brukt en ugyldig verdi. Men det skal de forhåpentligvis ikke ha gjort, da. Hva tenker du?

Veldig bra innstramming! Tenker minor bør holde for dette ja

@aurorascharff aurorascharff changed the title Add theme types to all themed components Enforce theme types to all themed components Sep 10, 2024
@aurorascharff aurorascharff changed the title Enforce theme types to all themed components Enforce theme types in all themed components Sep 10, 2024
@aurorascharff aurorascharff merged commit b2f2dab into main Sep 10, 2024
3 checks passed
@aurorascharff aurorascharff deleted the type-theme branch September 10, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajsaeggum kajsaeggum kajsaeggum approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurorascharff @kajsaeggum