Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly extend MdLink and MdTile with button/anchor-attributes #159

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

aurorascharff
Copy link
Contributor

Describe your changes

It was not possible to add button/achor-props like aria-attributes or classname to MdLink, MdTile and MdVerticalTile. Converted their props to types and extended correctly.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff aurorascharff changed the title Correctly extend MdLink and MdTile with button/achor-attributes Correctly extend MdLink and MdTile with button/anchor-attributes Sep 1, 2024
@aurorascharff aurorascharff marked this pull request as ready for review September 1, 2024 16:00
@aurorascharff aurorascharff requested a review from a team as a code owner September 1, 2024 16:00
@aurorascharff
Copy link
Contributor Author

@kajsaeggum Hei Kajsa, hva tenker du om denne løsningen? Mtp. at det var du som gjorde den opprinnelige utvidelsen av props.

@aurorascharff aurorascharff merged commit aeb8b43 into main Sep 3, 2024
3 checks passed
@aurorascharff aurorascharff deleted the fix-link-props branch September 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants