Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Buggy behavior with displayvalue in Autocomplete-components #157

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

aurorascharff
Copy link
Contributor

Describe your changes

When escaping or pressing enter inside autocompletes, displayvaue was shown and user could no longer type. Fixed.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@aurorascharff aurorascharff marked this pull request as ready for review August 24, 2024 10:28
@aurorascharff aurorascharff requested a review from a team as a code owner August 24, 2024 10:28
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

Copy link

@thomaslarsson thomaslarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aurorascharff aurorascharff merged commit f6a163e into main Aug 27, 2024
3 checks passed
@aurorascharff aurorascharff deleted the fix-autocomplete-displayvalue branch August 27, 2024 12:56
aurorascharff added a commit that referenced this pull request Sep 17, 2024
…splayvalue was shown and user could no longer type (#157)
@aurorascharff aurorascharff mentioned this pull request Sep 17, 2024
5 tasks
aurorascharff added a commit that referenced this pull request Sep 17, 2024
…splayvalue was shown and user could no longer type (#157) (#174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants