Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for usage with Rails in API mode #796

Merged
merged 4 commits into from
Feb 5, 2019

Conversation

ameft
Copy link
Contributor

@ameft ameft commented Feb 5, 2019

I had to scratch my head a lot to find the solution in the scenario.
This SO answers helped a lot:
https://stackoverflow.com/a/41050206
https://stackoverflow.com/a/51145337

Copy link
Collaborator

@unixmonkey unixmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example. Sorry the build isn't passing right now, I'll have to look into that, but it's not from anything you did here.

If you can either fix the typo or remove the comment line entirely, I'll be happy to merge this!

README.md Outdated

If you need to return a PDF in a controller with Rails in API mode:
```ruby
# teamplate in `app/views/controller_name/action_name.html.erb` and layout in `app/views/layouts/pdf.html.erb`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here: teamplate => template, and I think this comment isn't necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks

@unixmonkey unixmonkey merged commit cf6c6f7 into mileszs:master Feb 5, 2019
@unixmonkey
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants