WIP: Gem binary locations #764
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automatically finds gems with wkhtmltopdf included, and uses their executable. reordered some locations, so that manual configuration always trumps autodetection.
and add what we done did to the README.
|
I love the idea of this. It's been turning out to be a bigger problem lately, and I've been instructing some people to start using a variation of this: WickedPdf.config = {
exe_path: "#{ENV['GEM_HOME']}/gems/wkhtmltopdf-binary-#{Gem.loaded_specs['wkhtmltopdf-binary'].version}/bin/wkhtmltopdf_linux_amd64"
}depending on which gem they are using. The binary doesn't always work when called from a binstub because the stub could be loading a different environment. Thank you for looking into this. ❤️ Let me know if you have any questions or need help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! A heads up!
I've been working on a patch that automatically discovers if any of the wkhtmltopdf-binary gems are installed. Along the way I made changes to the way the executable is discovered.
I think it's an improvement. At this stage I would like to know what you think.
It might be close to done or not quite yet. I'm ready for any scenario. ;)