Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all modules and classes into WickedPdf namespace #538

Merged
merged 1 commit into from
May 24, 2016

Conversation

yui-knk
Copy link
Contributor

@yui-knk yui-knk commented May 23, 2016

It is not good to expose modules and classes except the root
namespace (WickedPdf), because someone define same name
modules or classes.
In this case, PdfHelper is a very common name for someone
to define a same name module.

It is not good to expose modules and classes except the root
namespace (`WickedPdf`), because someone define same name
modules or classes.
In this case, `PdfHelper` is a very common name for someone
to define a same name module.
@unixmonkey unixmonkey merged commit 1a71852 into mileszs:master May 24, 2016
@unixmonkey
Copy link
Collaborator

Yeah, buddy! Thanks :)

@yui-knk yui-knk deleted the inside_namespace branch May 24, 2016 03:17
@yui-knk
Copy link
Contributor Author

yui-knk commented May 24, 2016

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants