-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Rework shortcodes to align with the community and support localization. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesj
force-pushed
the
redo-shortcodes
branch
from
August 11, 2020 23:02
6d55d30
to
9afbe6d
Compare
milesj
force-pushed
the
redo-shortcodes
branch
from
August 12, 2020 01:14
ff41c68
to
f7b6b84
Compare
This was referenced Aug 12, 2020
milesj
force-pushed
the
redo-shortcodes
branch
from
August 13, 2020 22:15
0223e38
to
677812c
Compare
milesj
force-pushed
the
redo-shortcodes
branch
from
August 13, 2020 23:01
677812c
to
841bac4
Compare
@strixaluco This is ready. Would you be able to test it if I published a pre-release? |
@milesj Thanks for such a prompt rework. I'll do my best to do the testing. |
This was referenced Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a rather large topic but I believe we have a path forward.
Solves #49, #51, #52, #53, #57
shortcodes
from existing datasets.meta/shortcodes.json
dataset.regex/shortcode
to support locales.