Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isal-sys dependency for shared isal #25

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Oct 7, 2024

Fix the isal-sys dependency not to use default-features, in order to support using shared isal. Otherwise, the default static feature always forces the static library.

Fix the isal-sys dependency not to use default-features, in order
to support using shared isal.  Otherwise, the default `static` feature
always forces the static library.
@milesgranger milesgranger merged commit 13be242 into milesgranger:main Oct 7, 2024
9 checks passed
@milesgranger
Copy link
Owner

Thank you!

@mgorny mgorny deleted the shared-isal branch October 7, 2024 17:32
@mgorny
Copy link
Contributor Author

mgorny commented Oct 7, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants