More work on LZMA / XZ support #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We don't use filter chains in our use case. I'm not sure if or how far people have dug into this and not reported it widely. |
milesgranger
force-pushed
the
support-lzma
branch
from
376ffe2 to
3bd98f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #127 and part of #126
I'm rather uncertain if I want to (yet) add support for Filter chains. I've set everything up here like it can.. but I don't know. How many people actually use this, maybe better to rip out and add upon request.
@lgray do you have any inclination on the wider use of specifying filter chains in the raw format?
Right now this is compatible with the lzma module's XZ and ALONE (legacy lzma) formats both with de/compression. Maybe that w/ the support for supplying
presetformatandcheckparameters is enough until someone actually asks for wider support in Filters and filter chains.